Skip to content

Mark failing tests KNOWNBUG [blocks: #2310, #3627] #3624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 31, 2018
Merged

Mark failing tests KNOWNBUG [blocks: #2310, #3627] #3624

merged 3 commits into from
Dec 31, 2018

Conversation

tautschnig
Copy link
Collaborator

Several tests fail on Windows, but this wasn't noticed due Powershell not aborting on failing commands. Fixes for these tests will follow.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig changed the title Mark failing tests KNOWNBUG [blocks: #2310] Mark failing tests KNOWNBUG [blocks: #2310, #3627] Dec 28, 2018
allredj
allredj reviewed Dec 28, 2018
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 57eada0).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/95900411

@tautschnig
Copy link
Collaborator Author

tautschnig commented Dec 28, 2018 •
edited
Loading

For the record: the fixes for these issues already exist, but I'll refrain from even posting them until #3627 has been resolved as they can't even be tested until then.

Fixes in #3636 and #3637.

@tautschnig
goto-cl does not print source lines
fa63ef1 
The regression was not running on Windows because of earlier failures.
@tautschnig
The first static_assert fails with goto-cl
a122ff4 
The regression test is not run on Windows due to earlier failures.
@tautschnig
Mark tests failing on Windows as KNOWNBUG
a3fe0f8 
All 35 fail with

File: arith_tools.cpp:196 function: from_integer
Condition: false
Reason: Precondition
allredj
allredj reviewed Dec 29, 2018
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: a3fe0f8).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/95939500

@tautschnig tautschnig merged commit d11ec53 into diffblue:develop Dec 31, 2018
@tautschnig tautschnig deleted the vs-knownbug branch December 31, 2018 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@kroening kroening kroening approved these changes

Assignees
No one assigned
Labels
blocker Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tautschnig @kroening @allredj